Skip to content

fix(OMN-11513): align pricing manifest keys with vLLM-served model IDs - #1735

Closed
jonahgabriel wants to merge 4 commits into
devfrom
jonah/b9-pricing-manifest-key-fix
Closed

fix(OMN-11513): align pricing manifest keys with vLLM-served model IDs#1735
jonahgabriel wants to merge 4 commits into
devfrom
jonah/b9-pricing-manifest-key-fix

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Renames two model keys added in PR chore(OMN-11513): update pricing manifest to current fleet model IDs #1733 to match the exact IDs returned by /v1/models on the serving endpoints
  • ModelPricingTable.estimate_cost() does exact-match dict lookup; keys must match delegation_events.delegated_to exactly
  • text-embedding-gte, deepseek-v4-flash, deepseek-v4-pro were already correct

Changes:

Old key New key Endpoint
qwen3.6-35b-a3b Qwen3.6-35B-A3B .201:8000
qwen3.6-27b-mtp-iq4xs Qwen3.6-27B-MTP-IQ4_XS.gguf .201:8001

Companion PR in omnimarket (PR #847) updates endpoint_registry.yaml to write matching model IDs into delegation events.

Verification

  • uv run pytest tests/ -k pricing -v: 69 tests passed
  • pre-commit run --files src/omnibase_infra/configs/pricing_manifest.yaml: all hooks passed including Lint pricing manifest seed keys and ONEX Contract Validation

Ticket

OMN-11513

Evidence-Ticket: OMN-11513
Evidence-Source: OCC#1607

@jonahgabriel
fix(B9): align pricing manifest keys with vLLM-served model IDs
5a676bc 
Rename the two local model keys added in PR 1733 to match the exact model
IDs returned by /v1/models on the serving endpoints. ModelPricingTable
does an exact-match dict lookup, so keys must match what gets written into
delegation_events.delegated_to via endpoint_registry.yaml.

- qwen3.6-35b-a3b → Qwen3.6-35B-A3B (matches .201:8000 /v1/models)
- qwen3.6-27b-mtp-iq4xs → Qwen3.6-27B-MTP-IQ4_XS.gguf (matches .201:8001 /v1/models)
- text-embedding-gte, deepseek-v4-flash, deepseek-v4-pro unchanged (already match)

69 pricing-related unit tests pass.
@coderabbitai

coderabbitai Bot commented May 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 5 reviews of capacity. Refill in 48 minutes and 48 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 840ccd58-4711-41d0-89df-aa874c664b3b

📥 Commits

Reviewing files that changed from the base of the PR and between c8209c8 and 4e6795c.

📒 Files selected for processing (1)
  • src/omnibase_infra/configs/pricing_manifest.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/b9-pricing-manifest-key-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel jonahgabriel changed the title fix(B9): align pricing manifest keys with vLLM-served model IDs fix(OMN-11513): align pricing manifest keys with vLLM-served model IDs May 25, 2026
@jonahgabriel
chore(OMN-11513): refresh receipt gate PR metadata
fed6777
@jonahgabriel
chore(OMN-11513): baseline service_kernel.py topic literals from PR #…
e5f2aad 
…1736

PR #1736 added intentional topic literal constants with onex-topic-allow
annotations but did not update topic_literal_baseline.txt. The Arch
Invariants CI check uses AST scanning and does not read inline annotations,
so these two lines are picked up as new violations in the PR merge check.
@jonahgabriel
fix(OMN-11513): remove topic literal baseline suppression
4e6795c
@jonahgabriel

jonahgabriel commented May 25, 2026

Copy link
Copy Markdown
Collaborator Author

Closing in favor of new PR from correctly named branch (branch naming must include ticket reference per receipt gate policy)

@jonahgabriel
jonahgabriel deleted the jonah/b9-pricing-manifest-key-fix branch June 11, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonahgabriel